Adrien Grand created LUCENE-6228:
------------------------------------

             Summary: Do not expose full-fledged scorers in 
LeafCollector.setScorer
                 Key: LUCENE-6228
                 URL: https://issues.apache.org/jira/browse/LUCENE-6228
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: Adrien Grand
            Assignee: Adrien Grand
             Fix For: Trunk, 5.1


Currently LeafCollector.setScorer takes a Scorer, which I don't like because 
several methods should never be called in the context of a Collector (like 
nextDoc or advance).

I think it's even more trappy for methods that might seem to work in some 
particular cases but will not work in the general case, like getChildren which 
will not work if you have a specialized BulkScorer or iterating over positions 
which will not work if you are in a MultiCollector and another leaf collector 
consumes positions too.

So I think we should restrict what can be seen from a collector to avoid such 
traps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to