[ 
https://issues.apache.org/jira/browse/LUCENE-6229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313800#comment-14313800
 ] 

Adrien Grand commented on LUCENE-6229:
--------------------------------------

bq. Could this functionality be provided in a different way that doesn't have 
the problems you want to address here? E.g. could users hint the search to 
require this functionality (needClauses?), which in turn leads to not using 
optimized implementations that cannot (easily) provide this information?

I'm not sure I would like an additional parameter. In the join module, we 
worked around the fact that boolean queries do not always expose getChildren() 
by creating a dedicated IndexSearcher impl that always uses scorers instead of 
bulk scorers (ToParentBlockJoinIndexSearcher in lucene/join). Maybe this thing 
could be moved to a more general-purpose like lucene/misc and we could document 
that this is the way to go if you want to have access to information about 
child scorers from a collector, at the cost of some potential slow down?

> Remove Scorer.getChildren?
> --------------------------
>
>                 Key: LUCENE-6229
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6229
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>
> This API is used in a single place in our code base: 
> ToParentBlockJoinCollector. In addition, the usage is a bit buggy given that 
> using this API from a collector only works if setScorer is called with an 
> actual Scorer (and not eg. FakeScorer or BooleanScorer like you would get in 
> disjunctions) so it needs a custom IndexSearcher that does not use the 
> BulkScorer API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to