[
https://issues.apache.org/jira/browse/LUCENE-6227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314159#comment-14314159
]
Robert Muir commented on LUCENE-6227:
-------------------------------------
+1 to the earlier patch. Can we add some comments in BooleanWeight that
'requiredScoring' is a subset of 'required'?
When reviewing the logic of e.g. req(), its not immediately obvious that its
correct without going up hundreds of lines to look at how 'required' and
'requiredScoring' buckets are created (e.g. a MUST clause will be in both
lists).
I'm also staring at req() and trying to figure out what happens if we have only
a single, non-scoring clause (yet needsScores=true for the BQ as a whole). I
suppose it falls through to the BoostedScorer case? Maybe we can add a simple
unit test for this case to ensure it does what its supposed to do?
> Add BooleanClause.Occur.FILTER
> ------------------------------
>
> Key: LUCENE-6227
> URL: https://issues.apache.org/jira/browse/LUCENE-6227
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: Trunk, 5.1
>
> Attachments: LUCENE-6227.patch, LUCENE-6227.patch, LUCENE-6227.patch,
> LUCENE-6227.patch
>
>
> Now that we have weight-level control of whether scoring is needed or not, we
> could add a new clause type to BooleanQuery. It would behave like MUST exept
> that it would not participate in scoring.
> Why do we need it given that we already have FilteredQuery? The idea is that
> by having a single query that performs conjunctions, we could potentially
> take better decisions. It's not ready to replace FilteredQuery yet as
> FilteredQuery has handling of random-access filters that BooleanQuery
> doesn't, but it's a first step towards that direction and eventually
> FilteredQuery would just rewrite to a BooleanQuery.
> I've been calling this new clause type FILTER so far, but feel free to
> propose a better name.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
