[ 
https://issues.apache.org/jira/browse/LUCENE-2324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982374#action_12982374
 ] 

Jason Rutherglen commented on LUCENE-2324:
------------------------------------------

Here's a potential plan for the locking.  I think we still need a global lock 
for flush status, abort, and deletes.  DocumentsWriterPerThreadPool has the 
getAndLock method so maybe we should add a global lock on it.

1) Add DWPTP.setFlushStatus(DWPT)
2) Add DWPTP.setAbortStatus(DWPT)
3) Add DWPTP.getFlushStatus(DWPT)
4) Add DWPTP.getAbortStatus(DWPT)
5) Add DWPTP.getAndLock(Thread requestingThread, DocumentsWriter 
documentsWriter, Document doc, Term delTerm)
6) Add DWPTP.[deleteTerm,deleteQuery]

Where each of these methods acquires a lock on DWPTP.  

I think it'll look somewhat like FlushControl, however the common parameter 
will be an idx to the appropriate DWPT, eg, getFlushPending(int idx).  
Alternatively instead of placing this in DWPTP, DW is another possible 
candidate.

> Per thread DocumentsWriters that write their own private segments
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2324
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2324
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: Realtime Branch
>
>         Attachments: LUCENE-2324-SMALL.patch, LUCENE-2324-SMALL.patch, 
> LUCENE-2324-SMALL.patch, LUCENE-2324-SMALL.patch, LUCENE-2324-SMALL.patch, 
> LUCENE-2324.patch, lucene-2324.patch, lucene-2324.patch, LUCENE-2324.patch, 
> test.out, test.out, test.out, test.out
>
>
> See LUCENE-2293 for motivation and more details.
> I'm copying here Mike's summary he posted on 2293:
> Change the approach for how we buffer in RAM to a more isolated
> approach, whereby IW has N fully independent RAM segments
> in-process and when a doc needs to be indexed it's added to one of
> them. Each segment would also write its own doc stores and
> "normal" segment merging (not the inefficient merge we now do on
> flush) would merge them. This should be a good simplification in
> the chain (eg maybe we can remove the *PerThread classes). The
> segments can flush independently, letting us make much better
> concurrent use of IO & CPU.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to