[
https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated LUCENE-6232:
------------------------------
Attachment: LUCENE-6232.patch
Attaching a patch that doesn't clean up all of the raw type warnings, but
certainly gets a lot of them with a new class {{ValueSourceContext}}
CollapseScore stuff in here would introduce a circular dependency, so maybe
that gets subclassed.
By my count there are still 7 calls left to {{put()}}, so it's at least a
manageable number. At this point we might be able to add docs that say this is
obviously unsafe, and supress the warnings if we can't think of anything better.
> Replace ValueSource context Map with a more concrete data type
> --------------------------------------------------------------
>
> Key: LUCENE-6232
> URL: https://issues.apache.org/jira/browse/LUCENE-6232
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Mike Drob
> Attachments: LUCENE-6232.patch
>
>
> Inspired by LUCENE-3973
> The context object used by ValueSource and friends is a raw Map that provides
> no type safety guarantees. In our current state, there are lots of warnings
> about unchecked casts, raw types, and generally unsafe code from the
> compiler's perspective.
> There are several common patterns and types of Objects that we store in the
> context. It would be beneficial to instead use a class with typed methods for
> get/set of Scorer, Weights, etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
