[ 
https://issues.apache.org/jira/browse/LUCENE-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320696#comment-14320696
 ] 

Mike Drob edited comment on LUCENE-6232 at 2/13/15 8:28 PM:
------------------------------------------------------------

Patch incorporating Yonik's feedback.


was (Author: mdrob):
Patch incorporating Yonic's feedback.

> Replace ValueSource context Map with a more concrete data type
> --------------------------------------------------------------
>
>                 Key: LUCENE-6232
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6232
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Mike Drob
>         Attachments: LUCENE-6232.patch, LUCENE-6232.patch, LUCENE-6232.patch
>
>
> Inspired by LUCENE-3973
> The context object used by ValueSource and friends is a raw Map that provides 
> no type safety guarantees. In our current state, there are lots of warnings 
> about unchecked casts, raw types, and generally unsafe code from the 
> compiler's perspective.
> There are several common patterns and types of Objects that we store in the 
> context. It would be beneficial to instead use a class with typed methods for 
> get/set of Scorer, Weights, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to