[ 
https://issues.apache.org/jira/browse/LUCENE-6244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321546#comment-14321546
 ] 

Robert Muir commented on LUCENE-6244:
-------------------------------------

This latest patch looks nice at a glance. 

Can you explain this comment a bit more, I'm not sure I understand:
{noformat}
Because things are structured differently, I lost the feature that we confirm 
at most one clause per doc
{noformat}

Why do we pass needsScores to these disjunctions? It seems to only optimize the 
case where someone doesnt needScores but calls freq() anyway, and I don't think 
we should optimize that. DisjunctionScorer already defers all scoring/freq so I 
don't think it needs this boolean at all.

> Approximations on disjunctions
> ------------------------------
>
>                 Key: LUCENE-6244
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6244
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6244.patch, LUCENE-6244.patch, wikibig.tasks
>
>
> Like we just did on exact phrases and conjunctions, we should also support 
> approximations on disjunctions in order to apply "matches()" lazily.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to