[
https://issues.apache.org/jira/browse/SOLR-6956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-6956:
----------------------------------------
Attachment: SOLR-6956.patch
There is no need to synchronize on the ZkStateReader's update lock inside the
Overseer. It may have been necessary in the past but I don't see why it is
useful today. The lock is anyway acquired by the reader if the cluster state is
refreshed forcefully.
This patch removes synchronization on the ZkStateReader.getUpdateLock inside
the Overseer. This patch also combines the two work queue loops in the Overseer
(first at overseer startup and second if refreshClusterState == true). I had
kept them separate during SOLR-6554 because I thought that acquiring the update
lock was necessary and we don't want to hold the lock while waiting for a peek.
> DeleteReplicaTest fails sometimes.
> ----------------------------------
>
> Key: SOLR-6956
> URL: https://issues.apache.org/jira/browse/SOLR-6956
> Project: Solr
> Issue Type: Test
> Reporter: Mark Miller
> Priority: Minor
> Attachments: DeleteReplicaTest-failure.log, SOLR-6956.patch
>
>
> I still see fails of this test sometimes:
> {noformat}
> java.lang.AssertionError: Should have had a good message here
> at
> __randomizedtesting.SeedInfo.seed([D765D9019AAF2D1E:56835719EDF04D22]:0)
> at org.junit.Assert.fail(Assert.java:93)
> at org.junit.Assert.assertTrue(Assert.java:43)
> at
> org.apache.solr.cloud.DeleteReplicaTest.deleteLiveReplicaTest(DeleteReplicaTest.java:138)
> at
> org.apache.solr.cloud.DeleteReplicaTest.doTest(DeleteReplicaTest.java:89)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
