[
https://issues.apache.org/jira/browse/SOLR-7116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328670#comment-14328670
]
David Smiley commented on SOLR-7116:
------------------------------------
bq. I think from looking at your patch, this should still be true? did you try
this in your manual tests?
I did not; and I don't believe it will do what you say _for the refinement
phase_ because (a) the code declared that it doesn't do this for refinement
requests -- see handleResponses() -- an excerpt is below. and (b) my reading
of the code for distributedProcess() shows {{new ShardRequest}} happening and
it's only used for facet.field refinement, and enqueuePivotFacetShardRequests()
creates its own as well just for pivot refinement. My patch doesn't change
that.
{code:java}
// at present PURPOSE_REFINE_FACETS and PURPOSE_REFINE_PIVOT_FACETS
// don't co-exist in individual requests, but don't assume that
// will always be the case
{code}
That said; I'm sure you know this confusing code more than I do and I would not
be too surprised to find out my understanding is wrong.
p.s. I'm on vacation this week so sorry for any delayed replies
> Facet refinement shard request should disable other faceting types
> ------------------------------------------------------------------
>
> Key: SOLR-7116
> URL: https://issues.apache.org/jira/browse/SOLR-7116
> Project: Solr
> Issue Type: Improvement
> Components: faceting
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 5.1
>
> Attachments: SOLR-7116__facet_refinement_opt.patch
>
>
> While examining FacetComponent in the process of adding the new facet.heatmap
> faceting type, I observed that distributed shard refinement requests were
> built by copying the existing parameters and then modifying ones pertinent to
> facet.field or facet.pivot depending on the type of refinement requests
> (which in turn only happens some of the time, not too often). Those are the
> only types of faceting that have a refinement phase. These refinement
> requests _should not_ have facet.query, facet.date, facet.range,
> facet.interval, or facet.heatpmap since they don't participate in
> refinement... and furthermore, facet.field and facet.pivot have their own
> dedicated refinement requests and so a facet.field request _should not_ have
> options for facet.pivot. But this isn't taken care of, just facet.query is
> removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
