[
https://issues.apache.org/jira/browse/SOLR-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14336416#comment-14336416
]
Ishan Chattopadhyaya commented on SOLR-7158:
--------------------------------------------
I like the path separator logic being exctracted into a helper method. Just
checked on Windows, it works fine!
A quick lookup at
http://en.wikipedia.org/wiki/Path_%28computing%29#Representations_of_paths_by_operating_system_and_shell
convinces me that we can actually hardcode "\\" for the check for separator.
That might also make it fine (more performant?) to replace
Pattern.quote(separator) with "\\\\"?
> ZkConfigManager filesystem separator fix for Windows
> ----------------------------------------------------
>
> Key: SOLR-7158
> URL: https://issues.apache.org/jira/browse/SOLR-7158
> Project: Solr
> Issue Type: Bug
> Reporter: Ishan Chattopadhyaya
> Assignee: Alan Woodward
> Attachments: SOLR-7158.patch, SOLR-7158.patch
>
>
> The separator for zk nodes is '/'. However, on Windows, while uploading the
> relative files nested within a directory (e.g. velocity\hit-plain.vm) contain
> '\'. This, apart from causing an inconsistency as compared to zk on posix
> systems, messed up the ZkCLITest on Windows where count of files in zk and
> files in the filesystem was compared.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
