[ 
https://issues.apache.org/jira/browse/LUCENE-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338308#comment-14338308
 ] 

Robert Muir commented on LUCENE-6299:
-------------------------------------

We should rethink how the patch adds CorruptIndexException to DR etc 
signatures. I don't like this. I would prefer IOException.

making it corruptindexexception means every single user has to think about this 
crazy ass corner case, then they are left thinking 'ok what should my catch 
block do if the index is corrupt'. It makes things too hard to use.

> IndexWriter's enforcement of 2.1B doc limits is buggy
> -----------------------------------------------------
>
>                 Key: LUCENE-6299
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6299
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Blocker
>             Fix For: 4.10.4, 5.0, Trunk, 5.1
>
>         Attachments: LUCENE-6299.patch, LUCENE-6299_addIndexes.patch
>
>
> E.g. if you pass an already > 2.1B docs to either addIndexes, it can fail to 
> enforce properly.
> IW's private reserveDocs should refuse to accept negative values.
> IW.deleteAll fails to set the pendingNumDocs to 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to