[
https://issues.apache.org/jira/browse/LUCENE-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14338729#comment-14338729
]
Michael McCandless commented on LUCENE-6299:
--------------------------------------------
bq. I don't like how deleteAll unconditionally sets pendingNumDocs. We are
synced on lots of things, but everywhere else except startup is using atomic
addAndGet with deltas so i don't worry. Can we do the same here?
OK, you mean something like pendingNumDocs.addAndGet(-pendingNumDocs.get())?
bq. I also don't like how addindexes now does the reserveDocs before a bunch of
i/o operations.
That's a good point ... I'll put it back where it was before, and put the "best
effort" check back in both addIndexes.
> IndexWriter's enforcement of 2.1B doc limits is buggy
> -----------------------------------------------------
>
> Key: LUCENE-6299
> URL: https://issues.apache.org/jira/browse/LUCENE-6299
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Priority: Blocker
> Fix For: 4.10.4, 5.0, Trunk, 5.1
>
> Attachments: LUCENE-6299-410x.patch, LUCENE-6299.patch,
> LUCENE-6299.patch, LUCENE-6299.patch, LUCENE-6299.patch,
> LUCENE-6299_addIndexes.patch
>
>
> E.g. if you pass an already > 2.1B docs to either addIndexes, it can fail to
> enforce properly.
> IW's private reserveDocs should refuse to accept negative values.
> IW.deleteAll fails to set the pendingNumDocs to 0.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
