[ 
https://issues.apache.org/jira/browse/LUCENE-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14340308#comment-14340308
 ] 

Robert Muir commented on LUCENE-6304:
-------------------------------------

is the hashcode/equals stuff needed here or can the superclass impls in Query 
be used? They seem to already have this logic.

In the tests, i would add a call to QueryUtils.check(q) to one of your 
matchnodocsqueries. This will do some tests on hashcode/equals.

> Add MatchNoDocsQuery that matches no documents
> ----------------------------------------------
>
>                 Key: LUCENE-6304
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6304
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 5.0
>            Reporter: Lee Hinman
>            Priority: Minor
>         Attachments: LUCENE-6304.patch, LUCENE-6304.patch
>
>
> As a followup to LUCENE-6298, it would be nice to have an explicit 
> MatchNoDocsQuery to indicate that no documents should be matched. This would 
> hopefully be a better indicator than a BooleanQuery with no clauses or (even 
> worse) null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to