[ 
https://issues.apache.org/jira/browse/LUCENE-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Lee Hinman updated LUCENE-6304:
-------------------------------
    Attachment: LUCENE-6304.patch

bq. is the hashcode/equals stuff needed here or can the superclass impls in 
Query be used?

The hashcode is required at least, because otherwise the QueryUtils.check(q) 
fails because both the MatchNoDocsQuery and the superclass Query have the same 
hashcode, and the anonymous "WhackyQuery" that QueryUtils creates shares the 
same hash code, so QueryUtils.checkUnequal() fails.

The .equals() stuff is not required though, it can use the superclass 
implementation. I've attached a new patch that does this.

> Add MatchNoDocsQuery that matches no documents
> ----------------------------------------------
>
>                 Key: LUCENE-6304
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6304
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 5.0
>            Reporter: Lee Hinman
>            Priority: Minor
>         Attachments: LUCENE-6304.patch, LUCENE-6304.patch, LUCENE-6304.patch
>
>
> As a followup to LUCENE-6298, it would be nice to have an explicit 
> MatchNoDocsQuery to indicate that no documents should be matched. This would 
> hopefully be a better indicator than a BooleanQuery with no clauses or (even 
> worse) null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to