[ 
https://issues.apache.org/jira/browse/LUCENE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-6317:
--------------------------------
    Attachment: LUCENE-6317.patch

Updated patch. I bumped segments_N, .fis, and .si to use the new methods.

In general i tried to push immutability / non-nullness into the corresponding 
apis more too.

I think this is safer and cleaner and helps with the memory issues Mike wants 
to tackle.

> Fix readStringStringMap api
> ---------------------------
>
>                 Key: LUCENE-6317
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6317
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Robert Muir
>             Fix For: Trunk, 5.1
>
>         Attachments: LUCENE-6317.patch, LUCENE-6317.patch
>
>
> Currently this api is not very efficient, and always returns a mutable map.
> Can we change it to allow immutability? its sad we don't return 
> Collections.emptyMap so its the same instance for all empty cases.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to