[ 
https://issues.apache.org/jira/browse/SOLR-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344457#comment-14344457
 ] 

Vamsee Yarlagadda commented on SOLR-7180:
-----------------------------------------

LGTM. One small concern.
{quote}
executor.invokeAll(startups);
executor.invokeAll(shutdowns);
{quote}
How do we know whether all the jetty runners came up/shutdown properly? 
invokeAll will return once the Future.isDone() on every task right. But it 
doesn't guarantee that there are no exceptions in the process.


> MiniSolrCloudCluster should startup and shutdown its jetties in parallel
> ------------------------------------------------------------------------
>
>                 Key: SOLR-7180
>                 URL: https://issues.apache.org/jira/browse/SOLR-7180
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: SOLR-7180.patch
>
>
> Followup to SOLR-7179.  Now JettySolrRunner doesn't use sysprops to pass 
> configuration, we can start up multiple runners in parallel.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to