[
https://issues.apache.org/jira/browse/SOLR-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14348204#comment-14348204
]
Shalin Shekhar Mangar commented on SOLR-7190:
---------------------------------------------
Yeah, I found this while chasing a faceting related performance problem. I
looked up the history of the changes and I found that the facet.method=fc was
changed from:
{code}
if (sf.hasDocValues()) {
counts = DocValuesFacets.getCounts(searcher, base, field,
offset,limit, mincount, missing, sort, prefix);
} else if (multiToken || TrieField.getMainValuePrefix(ft) != null) {
UnInvertedField uif = UnInvertedField.getUnInvertedField(field,
searcher);
counts = uif.getCounts(searcher, base, offset, limit,
mincount,missing,sort,prefix);
} else {
counts = getFieldCacheCounts(searcher, base, field, offset,limit,
mincount, missing, sort, prefix);
}
{code}
to:
{code}
counts = DocValuesFacets.getCounts(searcher, base, field,
offset,limit, mincount, missing, sort, prefix);
{code}
in LUCENE-5666. Actually DocValuesFacets was introduced in SOLR-4490 but then
it was enabled only for doc value fields and later LUCENE-5666 switched to
using it always and removed the use of UninvertedField.
> Remove unused UninvertedField
> -----------------------------
>
> Key: SOLR-7190
> URL: https://issues.apache.org/jira/browse/SOLR-7190
> Project: Solr
> Issue Type: Task
> Reporter: Shalin Shekhar Mangar
> Priority: Minor
> Fix For: Trunk, 5.1
>
>
> I was surprised to find that UninvertedField is no longer used in Solr. The
> only references to UninvertedField is from the fieldValueCache inside
> SolrIndexSearcher and that itself is not used anywhere in SolrIndexSearcher
> except for initialization and regeneration. I can't trace when Solr stopped
> using this class but in any case, we should remove it.
> In a related note, Lucene's DocTermOrds has a copy of the class level
> javadocs of UninvertedField (which extends DocTermOrds). This was done in in
> LUCENE-5666.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
