Interesting - never seen such a thing with Eclipse - anyone else? I just select the new block of code and shift + control + F. Not bad, but would love to have that option as well.
I usually avoid fixing extra formatting in my patches, but for some of the super violations (someone just uses a complete different idea of code formatting) I'd rather it be fixed than worry about diffs. This type of thing proliferates and lately it feels like it's been going down hill. - Mark On Mon, Mar 9, 2015 at 10:00 AM Erick Erickson <[email protected]> wrote: > Ishan: > > Don't know which IDE you use, but IntelliJ has an "only vcs changed > code" or some such when reformatting that I find _very_ useful. It's a > bit dangerous because the _last_ thing you want to do is reformat > entire files, makes it really hard to look at diffs but I find the > ability to reformat just what's changed great!. > > Best, > Erick > > On Mon, Mar 9, 2015 at 12:41 AM, Ishan Chattopadhyaya (JIRA) > <[email protected]> wrote: > > > > [ https://issues.apache.org/jira/browse/SOLR-6673?page= > com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel&focusedCommentId=14352639#comment-14352639 ] > > > > Ishan Chattopadhyaya edited comment on SOLR-6673 at 3/9/15 7:40 AM: > > -------------------------------------------------------------------- > > > > Apologies for the inconsistent formatting; I'll keep this in mind :-) > Thanks for calling it out! > > > > Updated the patch with changes going to SolrLogLayout, adding the MDC > values in this format: > > > > [core] [collection] [shard] [replica] > > > > > > > > was (Author: ichattopadhyaya): > > Apologies for the inconsistent formatting; I'll keep this in mind :-) > Thanks for calling it out! > > > > Updated the patch with changes going to SolrLogLayout, adding the MDC > values in this format: > > [%X{core}] [%X{collection}] [%X{shard}] [%X{replica}] > > > > > >> MDC based logging of collection, shard etc. > >> ------------------------------------------- > >> > >> Key: SOLR-6673 > >> URL: https://issues.apache.org/jira/browse/SOLR-6673 > >> Project: Solr > >> Issue Type: Improvement > >> Reporter: Ishan Chattopadhyaya > >> Assignee: Noble Paul > >> Labels: logging > >> Attachments: SOLR-6673.patch, SOLR-6673.patch, SOLR-6673.patch, > log4j.properties, log4j.properties > >> > >> > >> In cloud mode, the many log items don't contain the collection name, > shard name, core name etc. Debugging becomes specially difficult when many > collections/shards are hosted on the same node. > >> The proposed solution adds MDC based stamping of collection, shard, > core to the thread. > >> See also: SOLR-5969, SOLR-5277 > > > > > > > > -- > > This message was sent by Atlassian JIRA > > (v6.3.4#6332) > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
