[ 
https://issues.apache.org/jira/browse/SOLR-7115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360270#comment-14360270
 ] 

Yonik Seeley commented on SOLR-7115:
------------------------------------

One thing I want to investigate: can exceeding maxWarmingSearchers  (in the 
case where there is a lot of commits) cause a commit to fail and cause a 
postCommit() to not be called?

Related: when a replica makes a recovery request to the leader (and the leader 
commits), is it possible for *that* commit to fail due to maxWarmingSearchers?  
My guess is "no" on this one because we shouldn't need to open a new searcher.

> UpdateLog can miss closing transaction log objects.
> ---------------------------------------------------
>
>                 Key: SOLR-7115
>                 URL: https://issues.apache.org/jira/browse/SOLR-7115
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Mark Miller
>
> I've seen this happen on YourKit and in various tests - especially since 
> adding resource release tracking to the log objects. Now I've got a test that 
> catches it in SOLR-7113.
> It seems that in precommit, if prevTlog is not null, we need to close it 
> because we are going to overwrite prevTlog with a new log.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to