[
https://issues.apache.org/jira/browse/SOLR-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-6350:
---------------------------
Attachment: SOLR-6350.patch
I spent some time today massaging Xu's latest patch to apply cleanly against
trunk.
Xu: please review and see if i missed anything?
A few notes...
* I didn't do any in depth review yet, but i did sprinkle some nocommits
arround related to things that jumped out at me while resolving conflicts
* StatsComponentTest.testPercentiles is failing for me (see below)
** does this fail for you? did i break something merging the patch?
* I didn't notice any distributed test, not sure if that's something still
needing done, or if that was just because of a mistake in creating the patch
file and "new files" weren't included.
* I tried to do some manual experimentation with this patch, and got really
bizare results...
** every percentile i requested came back as "NaN"
** if i requested more then one percentile value, i got a redundent percentiles
block in the response for each, eg...{noformat}
...&stats.field={!percentiles="1,99,99.9"}price
"stats":{
"stats_fields":{
"price":{
"percentiles":[
"1","NaN",
"99","NaN",
"99.9","NaN"],
"percentiles":[
"1","NaN",
"99","NaN",
"99.9","NaN"],
"percentiles":[
"1","NaN",
"99","NaN",
"99.9","NaN"]}}}}
{noformat}
** these results reproduced with both {{bin/solr -e techproducts}} and
{{bin/solr -e cloud}} (in the later case using some synthetic data (generated
by the same script used in SOLR-6349)
Test failure i mentioned...
{noformat}
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=StatsComponentTest
-Dtests.method=testPercentiles -Dtests.seed=EA16B33E5685B22 -Dtests.slow=true
-Dtests.locale=mk_MK -Dtests.timezone=Pacific/Niue -Dtests.asserts=true
-Dtests.file.encoding=ISO-8859-1
[junit4] FAILURE 1.27s | StatsComponentTest.testPercentiles <<<
[junit4] > Throwable #1: java.lang.AssertionError: Difference too much
[junit4] > at
__randomizedtesting.SeedInfo.seed([EA16B33E5685B22:3A66CB07A30CD216]:0)
[junit4] > at
org.apache.solr.handler.component.StatsComponentTest.testPercentiles(StatsComponentTest.java:1447)
[junit4] > at java.lang.Thread.run(Thread.java:745)
{noformat}
BTW: no need ot put your name as a suffix in the patch filename -- convention
is to just name the patch after the jira. The only reason to worry about
distinguishing the file names is in cases where you explicitly posting a
"variant" patch (ie: a strawman that you feel/know is broken and shouldn't be
taken seriously long term, an alternative proposal to some other existing
patch, an orthogonal patch only containing tests or some other independent
changes, etc...)
> Percentiles in StatsComponent
> -----------------------------
>
> Key: SOLR-6350
> URL: https://issues.apache.org/jira/browse/SOLR-6350
> Project: Solr
> Issue Type: Sub-task
> Reporter: Hoss Man
> Attachments: SOLR-6350-Xu.patch, SOLR-6350-Xu.patch,
> SOLR-6350-xu.patch, SOLR-6350-xu.patch, SOLR-6350.patch
>
>
> Add an option to compute user specified percentiles when computing stats
> Example...
> {noformat}
> stats.field={!percentiles='1,2,98,99,99.999'}price
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
