[
https://issues.apache.org/jira/browse/LUCENE-6350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372617#comment-14372617
]
Michael McCandless commented on LUCENE-6350:
--------------------------------------------
I think we should commit LUCENE-6315 (simplifies this package-private
iterator) before making this iterator public? Also, can you mark
PrefixCodedTerms @internal (NOT @experimental) before making it public?
This is not intended to be a publicly consumable API.
You don't need to do the field.equals(lastField) on each term? The
iterator tells you when it switches to a new field.
You added an "if (disi == null)" check, which is great; do we have a
test that tickles that?
Is RAMFile.equals/hashCode or PrefixCodedTerms.equals/hashCode ever
used anywhere else in the code base (because now they are quite
costly)? I assume not...
> switch TermsQuery to prefixcodedterms
> -------------------------------------
>
> Key: LUCENE-6350
> URL: https://issues.apache.org/jira/browse/LUCENE-6350
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Robert Muir
> Attachments: LUCENE-6350.patch, LUCENE-6350.patch
>
>
> This will save ram and cleanup a lot of the code.
> Unfortunately the code is still a mess, it has a custom iterator api, and
> prefixcodedterms has yet another custom iterator api (seriously, maybe the
> worst one ever).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
