[
https://issues.apache.org/jira/browse/SOLR-7296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377839#comment-14377839
]
Toke Eskildsen commented on SOLR-7296:
--------------------------------------
The String faceting in SimpeFacet could be cleaned up as it takes 3 or 4
nearly-the-same-code paths depending on DocValues and multi/single-value. An
abstraction in something like value-provider, doc->ordinal map, counting and
extraction should work well. Probably with some extra decorator or aggregator
elements. Hopefully including per-segment faceting. I makes a lot of sense to
clean that up and treat is as a whole.
Everything involving numerics is somewhat different as there are no ordinals:
All values are provided directly by the sources. There is also the possibility
of ongoing aggregation, such as finding the average or max. I am not sure it
would work well to share the numerics processing core with String-oriented
faceting.
> Reconcile facetting implementations
> -----------------------------------
>
> Key: SOLR-7296
> URL: https://issues.apache.org/jira/browse/SOLR-7296
> Project: Solr
> Issue Type: Task
> Components: faceting
> Reporter: Steve Molloy
>
> SOLR-7214 introduced a new way of controlling faceting, the unmbrella
> SOLR-6348 brings a lot of improvements in facet functionality, namely around
> pivots. Both make a lot of sense from a user perspective, but currently have
> completely different implementations. With the analytics components, this
> makes 3 implementation of the same logic, which is bound to behave
> differently as time goes by. We should reconcile all implementations to ease
> maintenance and offer consistent behaviour no matter how parameters are
> passed to the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
