[
https://issues.apache.org/jira/browse/SOLR-7298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated SOLR-7298:
-----------------------------
Attachment: SOLR-7298.patch
Added CollectionAdminRequestRequiredParamsTest which verifies that all
requests' default parameters are only their required parameters and none else.
If a request changes in the future, the test will break and it will remind us
to check documentation etc.
Also, I moved ClusterStatus to extend CollectionAdminRequest directly, at the
expense of adding setter/getter for collection and shard names, as these are
optional parameters for this request, yet CollectionShardAdminRequest always
adds them. Because they are null (if unset), ModifiableSolrParams eventually
does not set them, but I consider this magic and not desired behavior.
> Fix Collections API SolrJ calls to not add name parameter when not needed
> -------------------------------------------------------------------------
>
> Key: SOLR-7298
> URL: https://issues.apache.org/jira/browse/SOLR-7298
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud, SolrJ
> Affects Versions: 5.0
> Reporter: Anshum Gupta
> Assignee: Shai Erera
> Attachments: SOLR-7298.patch, SOLR-7298.patch,
> collection_api_params.xls
>
>
> Collections API SolrJ calls add the name parameter for a lot of calls
> incorrectly. It should only be added when required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
