[ 
https://issues.apache.org/jira/browse/LUCENE-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394688#comment-14394688
 ] 

Adrien Grand commented on LUCENE-6391:
--------------------------------------

bq. Since SpanScorer is a "bridge" from Spans to Scorer, most things except 
scoring should be final and just go to the spans. 

Yes... it is also important for approximations. Since the approximation and the 
scorer are supposed to be views of each other, it is usually wrong to eg. cache 
the current doc id.

> Give SpanScorer two-phase iterator support.
> -------------------------------------------
>
>                 Key: LUCENE-6391
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6391
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6391.patch
>
>
> Fix SpanScorer to use any two-phase iterator support of the underlying Spans. 
> This means e.g. a spans in a booleanquery, or a spans with a filter can be 
> faster.
> In order to do this, we have to clean up this class a little bit:
> * forward most methods directly to the underlying spans.
> * ensure positions are only iterated at most once.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to