[
https://issues.apache.org/jira/browse/LUCENE-6376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396060#comment-14396060
]
David Smiley commented on LUCENE-6376:
--------------------------------------
Okay; I'm in no hurry to add the things I said so please go ahead and learn how
things work so that you can do likewise. You already know how to add a patch I
see; you're doing what you supposed to do in terms of contributing. Check out:
http://wiki.apache.org/lucene-java/HowToContribute
BTW along with the change you did, update the spatial test infrastructure to
not uninvert this strategies fields. See SpatialTestCase.setup:
{code:java}
// TODO: change this module to index docvalues instead of uninverting
uninvertMap.clear();
uninvertMap.put("pointvector__x", Type.DOUBLE);
uninvertMap.put("pointvector__y", Type.DOUBLE);
{code}
should become simply uninvertMap.clear(); The comment no longer applies as we
no longer invert with your patch.
> Spatial PointVectorStrategy should use DocValues
> -------------------------------------------------
>
> Key: LUCENE-6376
> URL: https://issues.apache.org/jira/browse/LUCENE-6376
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial
> Reporter: David Smiley
> Attachments: LUCENE-6376.patch
>
>
> PointVectorStrategy.createIndexableFields should be using DocValues, like
> BBoxStrategy does. Without this, UninvertingReader is required.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
