[ 
https://issues.apache.org/jira/browse/LUCENE-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14483370#comment-14483370
 ] 

Dawid Weiss commented on LUCENE-6406:
-------------------------------------

Hi Adrien. I realize LTC has some overhead, but I'd argue that for consistency 
and sanity reasons all the test suites should be extending this top-level 
class. This helps in setting up common safety guards consistently (thread leak 
checks, etc.).

Ideally, it should be a compile-time error to have a test class *not* extending 
LTC (directly or indirectly). I can't think of a way to do it at the moment 
though.

> LuceneTestCase does not reset the original query cache
> ------------------------------------------------------
>
>                 Key: LUCENE-6406
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6406
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>             Fix For: Trunk, 5.1
>
>
> LuceneTestCase overrides the default query cache so that every test runs with 
> its own cache and is reproducible. But it does not reset the query cache when 
> it is finished. As a consequence, any other suite running in the same runner 
> and not inheriting LuceneTestCase will inherit a "dirty" query cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to