[
https://issues.apache.org/jira/browse/SOLR-7355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484401#comment-14484401
]
Shawn Heisey commented on SOLR-7355:
------------------------------------
I personally am ignorant about both Google's code and your code. Given that, I
have two primary concerns:
* Making sure the license is compatible and will remain compatible for the
foreseeable future.
* Ensuring that we don't take a step backwards in performance, and ideally,
that performance is improved.
If these concerns are not a problem, then I have no opposition to your patch
going in, but others may have technical questions or concerns. If any of those
come up, they will need to be addressed.
> Java 8: ConcurrentLinkedHashMap -> Caffeine
> -------------------------------------------
>
> Key: SOLR-7355
> URL: https://issues.apache.org/jira/browse/SOLR-7355
> Project: Solr
> Issue Type: Task
> Reporter: Ben Manes
> Priority: Minor
> Attachments: SOLR-7355.patch
>
>
> When Solr transitions to requiring Java 8, please upgrade to Caffeine. The
> performance should be relatively the same. The per-instance memory usage
> should be smaller and Solr may decide to opt-in to use some of the additional
> features. The only drawback is that the jar size is larger due to code
> generation, though that may be trimmed over time and usually is not a concern
> for server-side applications.
> ConcurrentLinkedHashMap changes will continue to be minimal, even more so
> now, and driven by requests from Java 6 users unable to upgrade. Caffeine is
> ideally the upgrade path for Guava cache users too, which due to Android
> cannot be significantly modified.
> Caffeine: https://github.com/ben-manes/caffeine
> Benchmarks: https://github.com/ben-manes/caffeine/wiki/Benchmarks
> ConcurrentLinkedHashMap: https://code.google.com/p/concurrentlinkedhashmap
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
