[ 
https://issues.apache.org/jira/browse/LUCENE-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487158#comment-14487158
 ] 

Robert Muir commented on LUCENE-6412:
-------------------------------------

Progress not perfection is not a motto of mine. I believe in good software 
design and thinking things through.

Making TermQuery a SpanQuery doesn't make sense unless we want to adopt the 
Spans api everywhere.

I don't think we should, at least in their current form. The API is undergoing 
heavy refactoring and cleanup and we are trying to improve the tests. 

my vote: please keep spans separate. They need a lot of work and it is not 
clear if / how they should be integrated any better. And core queries like term 
query need to stay the hell away from spans right now. 

These must work, and must have good performance. people really rely on them.

> Merge SpanTermQuery into TermQuery
> ----------------------------------
>
>                 Key: LUCENE-6412
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6412
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: Trunk, 5.2
>            Reporter: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-6412.patch
>
>
> Having a separate SpanTermQuery doesn't actually gain us anything now, and 
> it's trivial enough to make TermQuery extend SpanQuery copy the getSpans() 
> and getField() impls over from STQ.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to