May be we should forbid calls to the two argument version of Paths.get. Especially given other wishes as well apart from Hdfs (like to use a different filesystem for tests), this call, which uses the default filesystem, seems to be a mistake waiting to happen.. On 9 Apr 2015 07:48, "Varun Thacker (JIRA)" <[email protected]> wrote:
> > [ > https://issues.apache.org/jira/browse/SOLR-6637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486843#comment-14486843 > ] > > Varun Thacker commented on SOLR-6637: > ------------------------------------- > > Oh that looks like my mistake. Sorry about that. > > We need to change this {{tmpIndex = Paths.get(solrCore.getDataDir(), > tmpIdxDirName).toString();}} to > {{Paths.get(solrCore.getDataDir()).resolve(tmpIdxDirName).toString();}} > > There were two more places which need to be corrected. I'll fix them. > > > Solr should have a way to restore a core > > ---------------------------------------- > > > > Key: SOLR-6637 > > URL: https://issues.apache.org/jira/browse/SOLR-6637 > > Project: Solr > > Issue Type: Improvement > > Reporter: Varun Thacker > > Assignee: Varun Thacker > > Fix For: Trunk, 5.2 > > > > Attachments: SOLR-6637.patch, SOLR-6637.patch, SOLR-6637.patch, > SOLR-6637.patch, SOLR-6637.patch, SOLR-6637.patch, SOLR-6637.patch, > SOLR-6637.patch, SOLR-6637.patch, SOLR-6637.patch > > > > > > We have a core backup command which backs up the index. We should have a > restore command too. > > This would restore any named snapshots created by the replication > handlers backup command. > > While working on this patch right now I realized that during backup we > only backup the index. Should we backup the conf files also? Any thoughts? > I could separate Jira for this. > > > > -- > This message was sent by Atlassian JIRA > (v6.3.4#6332) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
