[ 
https://issues.apache.org/jira/browse/SOLR-7274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491303#comment-14491303
 ] 

Anshum Gupta commented on SOLR-7274:
------------------------------------

Thanks for putting up this patch Ishan.
I just had a quick look and most of my concerns were covered by [~gchanan]! 
Thanks for looking at this. It would be good to have more details about 
AuthenticationLayerPlugin and what needs to be implemented.

bq. 3. params.put("token.valid", System.getProperty("kerberos.name.rules", 
"30"));
bq. This doesn't look correct
This just seems like a typo.

This change I assume is also just for the purpose of testing/dev, right?
{code}
-log4j.logger.org.apache.hadoop=WARN
+log4j.logger.org.apache.hadoop=TRACE
{code}

About forwarding of requests, do you think we could borrow the code to send a 
repeatable request beforehand in case of POST/PUT? Or does it make sense to fix 
SOLR-6625 ?

Minor but can you also fix the parameters to more understandable names instead 
of arg(0|1|..)?

Most importantly, unless I'm missing out on something, are you propagating the 
userPrincipal out of the plugin and back to Solr?

> Pluggable authentication module in Solr
> ---------------------------------------
>
>                 Key: SOLR-7274
>                 URL: https://issues.apache.org/jira/browse/SOLR-7274
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Anshum Gupta
>         Attachments: SOLR-7274.patch
>
>
> It would be good to have Solr support different authentication protocols.
> To begin with, it'd be good to have support for kerberos and basic auth.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to