[ 
https://issues.apache.org/jira/browse/LUCENE-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14491694#comment-14491694
 ] 

Karl Wright commented on LUCENE-6196:
-------------------------------------

Hi David,

Your test fails because it is trying to define shapes using lat/lon in degrees. 
 geo3d uses radians for everything.

Also, when I apply the patch to current lucene trunk, I get 10 build errors.  
Looks like the lucene javadoc settings are blowing up the build:

{code}
    [javac] 
C:\wip\lucene\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoConvexPolygon.java:40:
 error: bad use of '>'
    [javac]     * Accepts only values in the following ranges: lat: -PI/2 -> 
PI/2, lon: -PI -> PI
    [javac]                                                                ^
    [javac] 
C:\wip\lucene\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoConvexPolygon.java:40:
 error: bad use of '>'
    [javac]     * Accepts only values in the following ranges: lat: -PI/2 -> 
PI/2, lon: -PI -> PI
    [javac]                                                                     
             ^
    [javac] 
C:\wip\lucene\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoConvexPolygon.java:56:
 error: bad use of '>'
    [javac]     * Accepts only values in the following ranges: lat: -PI/2 -> 
PI/2, lon: -PI -> PI
    [javac]                                                                ^
    [javac] 
C:\wip\lucene\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoConvexPolygon.java:56:
 error: bad use of '>'
    [javac]     * Accepts only values in the following ranges: lat: -PI/2 -> 
PI/2, lon: -PI -> PI
{code}




> Include geo3d package, along with Lucene integration to make it useful
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-6196
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6196
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: modules/spatial
>            Reporter: Karl Wright
>            Assignee: David Smiley
>         Attachments: LUCENE-6196_Geo3d.patch, ShapeImpl.java, 
> geo3d-tests.zip, geo3d.zip
>
>
> I would like to explore contributing a geo3d package to Lucene.  This can be 
> used in conjunction with Lucene search, both for generating geohashes (via 
> spatial4j) for complex geographic shapes, as well as limiting results 
> resulting from those queries to those results within the exact shape in 
> highly performant ways.
> The package uses 3d planar geometry to do its magic, which basically limits 
> computation necessary to determine membership (once a shape has been 
> initialized, of course) to only multiplications and additions, which makes it 
> feasible to construct a performant BoostSource-based filter for geographic 
> shapes.  The math is somewhat more involved when generating geohashes, but is 
> still more than fast enough to do a good job.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to