[
https://issues.apache.org/jira/browse/SOLR-7381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-7381:
----------------------------------------
Attachment: SOLR-7381.patch
# JettySolrRunner takes care to not pollute the caller thread with the context
set by Solr's init and destroy
# I added the following to forbidden-apis for Solr only so that we don't
accidentally create non-MDC aware thread pools:
{code}
java.util.concurrent.Executors#newFixedThreadPool(int,java.util.concurrent.ThreadFactory)
java.util.concurrent.Executors#newSingleThreadExecutor(java.util.concurrent.ThreadFactory)
java.util.concurrent.Executors#newCachedThreadPool(java.util.concurrent.ThreadFactory)
{code}
I'll commit this shortly.
> Improve logging by adding MDC context in more places
> ----------------------------------------------------
>
> Key: SOLR-7381
> URL: https://issues.apache.org/jira/browse/SOLR-7381
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Priority: Critical
> Fix For: 5.2
>
> Attachments: SOLR-7381.patch, SOLR-7381.patch
>
>
> SOLR-6673 added MDC based logging in a few places but we have a lot of ground
> to cover. Threads created via thread pool executors do not inherit MDC values
> and those are some of the most interesting places to log MDC context. This is
> critical to help debug SolrCloud failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
