[
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492559#comment-14492559
]
Noble Paul edited comment on SOLR-7110 at 4/13/15 4:19 PM:
-----------------------------------------------------------
Which test did you use? Did u use the checked in tests or created new ones?
What is important is probably the absolute numbers. if it is slower by a few of
nanoseconds and you get better memory efficiency it should be worth it. In %age
of time taken in deserialization is already insignificant
a 100% or near 100% cache hit will not be unusual , if you have cache a few
1000 strings because our keys are mostly repeated
was (Author: noble.paul):
Which test did you use? Did u use the checked in tests or created new ones?
What is important is probably the absolute numbers. if it is slower by a few of
nanoseconds and you get better memory efficiency it should be worth it. In %age
of time taken in deserialization is already insignificant
> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
> Key: SOLR-7110
> URL: https://issues.apache.org/jira/browse/SOLR-7110
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Minor
> Fix For: Trunk, 5.2
>
> Attachments: SOLR-7110.patch, SOLR-7110.patch, SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are
> repeated in the same payload. if we use a cache it is possible to avoid
> string creation across objects as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
