[ 
https://issues.apache.org/jira/browse/SOLR-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14492695#comment-14492695
 ] 

Shawn Heisey commented on SOLR-3935:
------------------------------------

Looking at the test infrastructure, I see both the nio and bio implementations 
imported into JettySolrRunner.  Although there is code that checks whether the 
connectorName is SelectChannel (nio) or Socket (bio), that code requires a test 
property to override the default of SelectChannel, and I don't see any 
indication that this override can happen automatically or randomly:

{code}
final String connectorName = System.getProperty("tests.jettyConnector", 
"SelectChannel");
{code}

I think that line that the tests will never choose bio connector types unless 
the *user* asks for it.  If that thought is correct, we are testing one jetty 
connector and shipping Solr with a config that uses another, which might lead 
to subtle bugs.


> Change the default jetty connector to be the NIO implementation.
> ----------------------------------------------------------------
>
>                 Key: SOLR-3935
>                 URL: https://issues.apache.org/jira/browse/SOLR-3935
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 4.9, Trunk
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to