[
https://issues.apache.org/jira/browse/LUCENE-6427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14498133#comment-14498133
]
Adrien Grand commented on LUCENE-6427:
--------------------------------------
bq. I don't see the problem with having a scanIsEmpty method available for
those willing to look for it.
But it doesn't bring anything either since this method is not used anywhere for
now?
bq. I moved the "Depends on the ghost bits being clear!" line from the doc
comments to a regular comment, except for the constructor (where the fact is
verified if assertions are enabled)
Thanks. Can you just remove the duplicated javadocs from oal.util.BitSet, the
javadoc tool should already inherit javadocs from overridden methods?
bq. I did remove a useless & 0x3f from FixedBitSet.flip in this patch as well
Good catch!
> BitSet fixes - assert on presence of 'ghost bits' and others
> ------------------------------------------------------------
>
> Key: LUCENE-6427
> URL: https://issues.apache.org/jira/browse/LUCENE-6427
> Project: Lucene - Core
> Issue Type: Bug
> Components: core/other
> Reporter: Luc Vanlerberghe
>
> Fixes after reviewing org.apache.lucene.util.FixedBitSet, LongBitSet and
> corresponding tests:
> * Some methods rely on the fact that no bits are set after numBits (what I
> call 'ghost' bits here).
> ** cardinality, nextSetBit, intersects and others may yield wrong results
> ** If ghost bits are present, they may become visible after ensureCapacity is
> called.
> ** The tests deliberately create bitsets with ghost bits, but then do not
> detect these failures
> * FixedBitSet.cardinality scans the complete backing array, even if only
> numWords are in use
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
