[
https://issues.apache.org/jira/browse/LUCENE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986116#action_12986116
]
Adriano Crestani commented on LUCENE-2457:
------------------------------------------
Hi Shai,
Please, don't close it, this is a nice feature, mainly for automated tests. I
haven't had time to give attention to it yet, but keep it in the open lis for
now,t so we don't forget it :)
> QueryNode implementors should override equals method
> ----------------------------------------------------
>
> Key: LUCENE-2457
> URL: https://issues.apache.org/jira/browse/LUCENE-2457
> Project: Lucene - Java
> Issue Type: Improvement
> Components: QueryParser
> Reporter: Adriano Crestani
> Priority: Minor
> Fix For: 3.2, 4.0
>
>
> Discussed on thread: http://markmail.org/thread/gjqk35t7e3y4fo5j
> "QueryNode(s) are data objects, and it makes sense to override
> their equals method. But before, we need to define what is a QueryNode
> equality. Should two nodes be considered equal if they represent
> syntactically or semantically the same query? e.g. an ORQueryNode created
> from the query <a OR b OR c> will not have the same children ordering as the
> query <b OR c OR a>, so they are syntactically not equal, but they are
> semantically equal, because the order of the OR operands (usually) does not
> matter when the query is executed. I say it usually does not matter, because
> it's up to the Query object implementation built from that ORQueryNode
> object, for this reason, I vote for defining that two query nodes should be
> equals if they are syntactically equal.
> I also vote for excluding query node tags from the equality check, because
> they are not meant to represent the query structure, but to attach extra
> info to the node, which is usually used for communication between
> processors."
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
