[
https://issues.apache.org/jira/browse/SOLR-7409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14505532#comment-14505532
]
Shawn Heisey commented on SOLR-7409:
------------------------------------
That -2 patch looks really good.
It looks like you re-used somebody else's code, specifically this project:
https://github.com/overset/javascript-natural-sort/blob/master/naturalSort.js
This isn't a problem. I believe we should probably use their source file which
includes the author and the license, which is MIT, and compatible with Solr's
license. I wonder if we need to include a license and notice file in
solr/licenses for this code.
Regarding patch attachments, normally they really should be just named after
the issue, for *every* upload, which means they all get named SOLR-7409.patch.
If I am making an alternate proposal on an issue that somebody else is working,
I will sometimes do a name like SOLR-7409-elyograg.patch to keep it separate
from the more official work in progress. Jira will automatically grey out all
but the newest version of each attachment that has the same name, but the older
ones will remain available. This is in line with the open source ideal of
keeping all discussion and development in the public view.
> Sort dataimport by name in gui
> ------------------------------
>
> Key: SOLR-7409
> URL: https://issues.apache.org/jira/browse/SOLR-7409
> Project: Solr
> Issue Type: Improvement
> Components: web gui
> Affects Versions: Trunk
> Reporter: Jellyfrog
> Priority: Trivial
> Attachments: SOLR-7409-1.patch, SOLR-7409-2.patch
>
>
> As discussed with steffkes on IRC
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
