[
https://issues.apache.org/jira/browse/LUCENE-6446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14507098#comment-14507098
]
Adrien Grand commented on LUCENE-6446:
--------------------------------------
bq. Should this method be private?
Good point, I'll fix.
bq. I find this extra context invaluable, especially with the decoupling of
score and match, we can't assume that a score of 0 is a NON-MATCH yet the
output no longer tells is if an explanation is a MATCH or not.
I removed it because it was not always in the summary (only when using
ComplexExplanation) as well as redundant with the description which is explicit
when there is no match, for instance TermWeight's "no matching term" or
BooleanWeight "no match on required clause"?
> Simplify Explanation API
> ------------------------
>
> Key: LUCENE-6446
> URL: https://issues.apache.org/jira/browse/LUCENE-6446
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: Trunk, 5.2
>
> Attachments: LUCENE-6446.patch
>
>
> We should make this API easier to consume, for instance:
> - enforce important components to be non-null (eg. description)
> - decouple entirely the score computation from whether there is a match or
> not (Explanation assumes there is a match if the score is > 0, you need to
> use ComplexExplanation to override this behaviour)
> - return an empty array instead of null when there are no "details"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
