[ 
https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518108#comment-14518108
 ] 

Hoss Man commented on LUCENE-6213:
----------------------------------

bq. When I added this logic, 5.0 was not yet released, so we didn't have an 
official release to build the mixed segments with.

Perhaps this is something smokechecker should sanity check for us moving 
forward?  It already parses the output of TestBackwardsCompatibility to make 
sure we test all known previous releases, why not also make it look for 
{{testIndexFormatTooOldExceptionX}} where {{X}} is 1 less then whatever the 
major version number is?

so smokechecker against trunk (where version is 6.0) will fail unless/until 
there is a {{testIndexFormatTooOldException5}} run as part of 
TestBackwardsCompatibility. when we create a branch_6x and update the version 
on trunk to "7" it will start failing again until we change 
TestBackwardsCompatibility so that {{testIndexFormatTooOldException6}} exists 
(a good and legitimate smoke test to fail: we don't want to release "trunk" 
until 6.0 is final and we have a mixed format to test against)



> Add test for IndexFormatTooOldException if a commit has a 3.x segment
> ---------------------------------------------------------------------
>
>                 Key: LUCENE-6213
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6213
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Ryan Ernst
>         Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, 
> unsupported.4x-with-3x-segments.zip
>
>
> We should add a 4.x index (4.x commit) with some 3.x segment(s) to our 
> backwards tests.
> I don't think we throw IndexFormatTooOldException correctly in this case. I 
> think instead the user will get a confusing SPI error about a missing codec 
> "Lucene3x".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to