[ 
https://issues.apache.org/jira/browse/SOLR-7485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522773#comment-14522773
 ] 

Shalin Shekhar Mangar commented on SOLR-7485:
---------------------------------------------

Maybe having the string constants in some tests isn't that bad? If someone 
accidentally changes the constant's value, there will be at least 1 test which 
catches the back-compat break.

> replace "shards.info" with ShardParams.SHARDS_INFO in TestTolerantSearch.java 
> and CloudSolrClientTest.java
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7485
>                 URL: https://issues.apache.org/jira/browse/SOLR-7485
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> various other tests already use ShardParams.SHARDS_INFO e.g. 
> TestDistributedSearch.java



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to