[ 
https://issues.apache.org/jira/browse/LUCENE-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Smiley updated LUCENE-6463:
---------------------------------
    Attachment: LUCENE-6463.patch

The patch looks good Adrien (+1).  The patch I'm uploading augments yours with 
a use of ConstantScorScorer in TermsQuery.  No other changes.

I’ve seen at least a few cases where we start from a DocIdSet and then check 
for null, then grab the DISI from it then check for null, and then finally 
return the constant scorer.  Perhaps a static method could be added like 
from(weight, score, DocIdSet)?  I'm not sure if it's worth the method but I 
thought I'd bring it up.


> Share more logic between our approximated queries
> -------------------------------------------------
>
>                 Key: LUCENE-6463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6463
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6463.patch, LUCENE-6463.patch, LUCENE-6463.patch
>
>
> We have several queries that support approximations, and in particular the 
> ones based on random-access (doc values terms/range, FieldValueFilter, ...) 
> duplicate some logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to