[ 
https://issues.apache.org/jira/browse/LUCENE-6463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14531371#comment-14531371
 ] 

Adrien Grand commented on LUCENE-6463:
--------------------------------------

bq. I’ve seen at least a few cases where we start from a DocIdSet and then 
check for null, then grab the DISI from it then check for null, and then 
finally return the constant scorer.

I agree this is horrible to deal with LUCENE-5117 (but complicated to fix). 
Hopefully moving to filters is going to make it less of an issue as we will not 
have to deal as much with DocIdSet as we had in the past.

Thanks for fixing TermsQuery too, it looks good! I'll commit the patch tomorrow 
if nobody has objections.

> Share more logic between our approximated queries
> -------------------------------------------------
>
>                 Key: LUCENE-6463
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6463
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6463.patch, LUCENE-6463.patch, LUCENE-6463.patch
>
>
> We have several queries that support approximations, and in particular the 
> ones based on random-access (doc values terms/range, FieldValueFilter, ...) 
> duplicate some logic.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to