Eric Wheeler created SOLR-7520:
----------------------------------
Summary: DelegatingCollector.finish not called for multi-shard
queries specifying grouping
Key: SOLR-7520
URL: https://issues.apache.org/jira/browse/SOLR-7520
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 4.8
Reporter: Eric Wheeler
The finish method for a DelegatingCollector post filter is not being called for
queries specifying a fq filter, multiple shards, and grouping options.
Recommend adding the following code to
org.apache.solr.search.grouping.CommandHandler.searchWithTimeLimiter to call
finish (if a DelegatingCollector is available) after calling search, but before
obtaining totalHitCount:
{code: title=org.apache.solr.search.grouping.CommandHandler line ~218}
try {
searcher.search(query, luceneFilter, collector);
} catch (TimeLimitingCollector.TimeExceededException x) {
partialResults = true;
logger.warn( "Query: " + query + "; " + x.getMessage() );
}
/* Call finish of DelegatingCollector to complete post processing
for multi-shard queries */
if (filter.postFilter != null) {
filter.postFilter.finish();
}
/* END: Call finish of DelegatingCollector to complete post processing
for multi-shard queries */
if (includeHitCount) {
totalHitCount = hitCountCollector.getTotalHits();
}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
