[
https://issues.apache.org/jira/browse/SOLR-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541868#comment-14541868
]
Steve Rowe commented on SOLR-7540:
----------------------------------
This fixes it:
{noformat}
Index: solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java
===================================================================
--- solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java
(revision 1679199)
+++ solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java
(working copy)
@@ -103,7 +103,7 @@
assertEquals("Wrong number of replicas found", 4, replicas.size());
for(Replica replica : replicas) {
assertTrue("Replica didn't have the proper urlScheme in the
ClusterState",
- StringUtils.startsWith(replica.getStr(ZkStateReader.BASE_URL_PROP),
urlScheme));
+ StringUtils.startsWith(replica.getStr(ZkStateReader.BASE_URL_PROP),
urlScheme + ":"));
}
}
{noformat}
> SSLMigrationTest urlScheme isn't tested properly
> ------------------------------------------------
>
> Key: SOLR-7540
> URL: https://issues.apache.org/jira/browse/SOLR-7540
> Project: Solr
> Issue Type: Bug
> Reporter: Steve Rowe
> Priority: Minor
>
> I noticed that {{SSLMigrationTest.assertReplicaInformation(urlScheme)}} only
> checks that a replicas' base url *starts with* the given url scheme - since
> the urlScheme can only be "http" or "https", this check will always succeed
> when the given urlScheme is "http".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
