[
https://issues.apache.org/jira/browse/SOLR-7541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545558#comment-14545558
]
Mark Miller commented on SOLR-7541:
-----------------------------------
+1, looks great.
> CollectionsHandler#createNodeIfNotExists is a duplicate of
> ZkCmdExecutor#ensureExists
> -------------------------------------------------------------------------------------
>
> Key: SOLR-7541
> URL: https://issues.apache.org/jira/browse/SOLR-7541
> Project: Solr
> Issue Type: Improvement
> Reporter: Varun Thacker
> Priority: Minor
> Attachments: SOLR-7541.patch, SOLR-7541.patch
>
>
> Looks like CollectionsHandler#createNodeIfNotExists is a duplicate of
> ZkCmdExecutor#ensureExists . Both do the same thing so we could remove
> CollectionsHandler#createNodeIfNotExists.
> Also looking at {{ZkCmdExecutor#ensureExists(final String path, final byte[]
> data,CreateMode createMode, final SolrZkClient zkClient)}} the createMode
> parameter is getting discarded.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
