[ 
https://issues.apache.org/jira/browse/LUCENE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557255#comment-14557255
 ] 

Michael McCandless commented on LUCENE-6481:
--------------------------------------------

Ooh, awesome progress!  I'll look in more detail, but: I applied the patch and 
hit this test failure:

{noformat}
ant test  -Dtestcase=TestGeoPointQuery -Dtests.method=testBBoxQuery 
-Dtests.seed=FC153607634373BA -Dtests.nightly=true -Dtests.slow=true 
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed 
-Dtests.locale=es -Dtests.timezone=Asia/Jerusalem -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8

   [junit4] Started J0 PID(14260@localhost).
   [junit4] Suite: org.apache.lucene.search.TestGeoPointQuery
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeoPointQuery 
-Dtests.method=testBBoxQuery -Dtests.seed=FC153607634373BA -Dtests.nightly=true 
-Dtests.slow=true 
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed 
-Dtests.locale=es -Dtests.timezone=Asia/Jerusalem -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.09s | TestGeoPointQuery.testBBoxQuery <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: GeoBoundingBoxQuery 
failed expected:<1> but was:<2>
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([FC153607634373BA:5CE7EC6FB0DC9159]:0)
   [junit4]    >        at 
org.apache.lucene.search.TestGeoPointQuery.testBBoxQuery(TestGeoPointQuery.java:113)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
   [junit4]   2> NOTE: leaving temporary files on disk at: 
/l/nick/lucene/build/sandbox/test/J0/temp/lucene.search.TestGeoPointQuery 
FC153607634373BA-001
   [junit4]   2> NOTE: test params are: codec=Asserting(Lucene50): 
{geoField=PostingsFormat(name=MockRandom)}, docValues:{}, 
sim=DefaultSimilarity, locale=es, timezone=Asia/Jerusalem
   [junit4]   2> NOTE: Linux 3.13.0-46-generic amd64/Oracle Corporation 
1.8.0_40 (64-bit)/cpus=8,threads=1,free=385990872,total=504889344
   [junit4]   2> NOTE: All tests run in this JVM: [TestGeoPointQuery]
   [junit4] Completed [1/1] in 0.48s, 1 test, 1 failure <<< FAILURES!
{noformat}

> Improve GeoPointField type to only visit high precision boundary terms 
> -----------------------------------------------------------------------
>
>                 Key: LUCENE-6481
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6481
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/index
>            Reporter: Nicholas Knize
>         Attachments: LUCENE-6481.patch, LUCENE-6481.patch, LUCENE-6481.patch, 
> LUCENE-6481.patch, LUCENE-6481_WIP.patch
>
>
> Current GeoPointField [LUCENE-6450 | 
> https://issues.apache.org/jira/browse/LUCENE-6450] computes a set of ranges 
> along the space-filling curve that represent a provided bounding box.  This 
> determines which terms to visit in the terms dictionary and which to skip. 
> This is suboptimal for large bounding boxes as we may end up visiting all 
> terms (which could be quite large). 
> This incremental improvement is to improve GeoPointField to only visit high 
> precision terms in boundary ranges and use the postings list for ranges that 
> are completely within the target bounding box.
> A separate improvement is to switch over to auto-prefix and build an 
> Automaton representing the bounding box.  That can be tracked in a separate 
> issue.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to