[ 
https://issues.apache.org/jira/browse/LUCENE-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558879#comment-14558879
 ] 

Karl Wright commented on LUCENE-6487:
-------------------------------------

Applying your patch against trunk yields:

{code}
    [mkdir] Created dir: 
C:\wip\lucene\lucene-6487\lucene\build\spatial\classes\java
    [javac] Compiling 106 source files to 
C:\wip\lucene\lucene-6487\lucene\build\spatial\classes\java
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoDegenerateHorizontalLine.java:27:
 error: cannot find symbol
    [javac] public class GeoDegenerateHorizontalLine extends GeoBaseBBox {
    [javac]                                                  ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoDegenerateLatitudeZone.java:26:
 error: cannot find symbol
    [javac] public class GeoDegenerateLatitudeZone extends GeoBaseBBox {
    [javac]                                                ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoDegenerateLongitudeSlice.java:25:
 error: cannot find symbol
    [javac] public class GeoDegenerateLongitudeSlice extends GeoBaseBBox {
    [javac]                                                  ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoDegenerateVerticalLine.java:25:
 error: cannot find symbol
    [javac] public class GeoDegenerateVerticalLine extends GeoBaseBBox {
    [javac]                                                ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoLatitudeZone.java:25:
 error: cannot find symbol
    [javac] public class GeoLatitudeZone extends GeoBaseBBox {
    [javac]                                      ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoLongitudeSlice.java:27:
 error: cannot find symbol
    [javac] public class GeoLongitudeSlice extends GeoBaseBBox {
    [javac]                                        ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoNorthLatitudeZone.java:25:
 error: cannot find symbol
    [javac] public class GeoNorthLatitudeZone extends GeoBaseBBox {
    [javac]                                           ^
    [javac]   symbol: class GeoBaseBBox
    [javac] 
C:\wip\lucene\lucene-6487\lucene\spatial\src\java\org\apache\lucene\spatial\spatial4j\geo3d\GeoNorthRectangle.java:28:
 error: cannot find symbol
    [javac] public class GeoNorthRectangle extends GeoBaseBBox {
...
{code}

Clearly we are out of sync again.

I'm attaching a new patch with my changes, but they do not include your changes 
for that reason.



> Add WGS84 capability to geo3d support
> -------------------------------------
>
>                 Key: LUCENE-6487
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6487
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: Karl Wright
>         Attachments: LUCENE-6487.patch, LUCENE-6487.patch
>
>
> WGS84 compatibility has been requested for geo3d.  This involves working with 
> an ellipsoid rather than a unit sphere.  The general formula for an ellipsoid 
> is:
> x^2/a^2 + y^2/b^2 + z^2/c^2 = 1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to