[ 
https://issues.apache.org/jira/browse/LUCENE-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558911#comment-14558911
 ] 

Uwe Schindler commented on LUCENE-6500:
---------------------------------------

Here is the problem, why the patch is problematic:
The current logic is fine, but fails - as Adrien says - when you have a 
ParallelMultiReader on a MultiReader of another CompositeReaders.
His fix works fine, if you have closeSubReader=false on the parallel on and 
also on the child MultiReaders. in that case it will fail with too many decRefs.
I am not sure how the best fix looks like. It this issue urgent? I have to 
think a night about it :-) I would prefer to have a better solution alltgether, 
this refcounting is horrible...

> ParallelCompositeReader does not always call closed listeners
> -------------------------------------------------------------
>
>                 Key: LUCENE-6500
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6500
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6500.patch
>
>
> CompositeParallelReader misses to call closed listeners when the reader which 
> is provided at construction time does not wrap leaf readers directly, such as 
> a multi reader over directory readers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to