[ 
https://issues.apache.org/jira/browse/SOLR-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561331#comment-14561331
 ] 

Dawid Weiss commented on SOLR-7601:
-----------------------------------

This should be close. AfterClass is invoked inside the class rule that detects 
failures so certain exceptions could happen in between, but individual tests 
should taint that suiteFailureMarker.

You will not be able to react to hanging threads -- this is initiated and 
executed outside of the test classes, followed by interrupt on the test thread 
(which then may throw random crap at the fan). This is chicken-and-egg problem, 
I don't think it's quite solvable. You should scan for failures in the log, 
top-to-bottom...

> If a test fails, that error should be reported and not an error about 
> resources that were not closed later.
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-7601
>                 URL: https://issues.apache.org/jira/browse/SOLR-7601
>             Project: Solr
>          Issue Type: Test
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>             Fix For: Trunk, 5.3
>
>         Attachments: SOLR-7601.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to