[ https://issues.apache.org/jira/browse/SOLR-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561926#comment-14561926 ]
Hrishikesh Gadre commented on SOLR-7344: ---------------------------------------- [~yo...@apache.org] >>I wonder what the performance implications of using continuations are? Note that the Jetty continuation API predates Servlet 3 specification. Hence to maintain backwards compatibility, latest version of Jetty implements continuation API using the Servlet 3 APIs under the hood. I could not find any recent reference suggesting bad performance of servlet 3 based implementation. There is one article (published in 2008) comparing the performance difference between thread-per-request model vs non-blocking IO (http://iobound.com/tag/jetty/). But given that the latest version of Jetty uses [NIO by default|http://stackoverflow.com/questions/25195128/how-do-jetty-and-other-containers-leverage-nio-while-sticking-to-the-servlet-spe], I am not sure how relevant this really is. Also as I mentioned before we will still get to use the thread-per-request model when the number of requests (of a specific type) are less than the capacity reserved for that request type. All the additional requests will be buffered in a Queue until at-least one thread is available for processing. Logically this is as good as having two separate endpoints each associated with a dedicated thread-pool and an accept queue. Anyway I think we should do a performance testing with this change to be certain. Please let me know if there are any concerns with this proposal. Otherwise I will start implementing this approach. > Use two thread pools, one for internal requests and one for external, to > avoid distributed deadlock and decrease the number of threads that need to be > created. > --------------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-7344 > URL: https://issues.apache.org/jira/browse/SOLR-7344 > Project: Solr > Issue Type: Improvement > Components: SolrCloud > Reporter: Mark Miller > Attachments: SOLR-7344.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org